Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pagination in blog view #78

Open
aldrineeinsteen opened this issue Jul 14, 2020 · 6 comments
Open

Enable pagination in blog view #78

aldrineeinsteen opened this issue Jul 14, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@aldrineeinsteen
Copy link

aldrineeinsteen commented Jul 14, 2020

Add configuration support in the blog section.

Am thinking about

[params]
  [params.blog]
     ...
     pagination = true
     paginate = 5
@jakewies
Copy link
Owner

@kentnek this is a feature I'd like to have a bigger discussion about. After some thought, I think it would be best to a have a default pagination setup for the blog list, and the default can be overridden using configuration such as @aldrineeinsteen has described.

What are your thoughts?

@kentnek
Copy link
Collaborator

kentnek commented Jul 14, 2020

I don't mind having a pagination, as long as the styling fits our overall look of the theme. I don't really dig the bright red page button in @aldrineeinsteen's PR, which instead can be a semi-transparent grey box like this existing Prev/Next button:

test

Also, the config should also be site-wide, not page-wide, as discussed earlier.

@jakewies
Copy link
Owner

Agreed on all accounts. The styles must fit the theme. And the config should exist in config.toml site wide. @aldrineeinsteen if you need help with styling let us know.

@miguelbemartin
Copy link

Is it possible to paginate the blog? I don't find the way...

@jakewies
Copy link
Owner

@miguelbemartin this feature is not yet supported. But it's something that's on the roadmap. If you'd like to contribute go for it!

@jakewies jakewies added enhancement New feature or request help wanted Extra attention is needed labels Oct 18, 2020
@miguelbemartin
Copy link

Thanks for your answer. I didn't use this theme in the end as it didn't have support for pagination. If not, I would be happy to help to contribute to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants