-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
animation shorthand first zero unit incorrectly dropped #988
Closed
Meesayen opened this issue
Nov 30, 2017
· 2 comments
· Fixed by dalton-0x0/cohort3#38 or grechut/watchdog#41 · May be fixed by kosiakMD/progressive_optimistic_ui#1, JuliusMorkunas/liker#16 or m0rphtail/Teleport#4
Closed
animation shorthand first zero unit incorrectly dropped #988
Meesayen opened this issue
Nov 30, 2017
· 2 comments
· Fixed by dalton-0x0/cohort3#38 or grechut/watchdog#41 · May be fixed by kosiakMD/progressive_optimistic_ui#1, JuliusMorkunas/liker#16 or m0rphtail/Teleport#4
Comments
Fair point, fixing it asap. |
jakubpawlowicz
added a commit
that referenced
this issue
Mar 5, 2018
When `animation-duration` is default but `animation-delay` isn't we shouldn't drop the former as both need to be given.
It's fixed in 4.1.10. |
This was referenced Mar 10, 2021
Merged
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
npm ls clean-css
: 4.1.9node -v
: 8.4.0Configuration options
Input CSS
Actual output CSS
Expected output CSS
Hi, I found out that for some reasons the
0s
unit in an animation shorthand is dropped, but in this case it can be a problem, because according to the specification the first time unit found in the shorthand is to be considered the "duration".So in the example above, by dropping the zero unit, we are transforming a non-animated, 5 second delayed transition, to a 5 seconds long animated transition. (it was quite a fun bug to see :D)
I tried different configurations, like adding
compatibility: { properties: { zeroUnits: false } }
, with no success.Using
level: { 2: { skipProperties: ['animation'] } }
helps but it would be nice to have those optimizations in place, clearly.The text was updated successfully, but these errors were encountered: