Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale de_DE not supported by fromNow() #70

Closed
SebRut opened this issue Jun 21, 2020 · 1 comment
Closed

Locale de_DE not supported by fromNow() #70

SebRut opened this issue Jun 21, 2020 · 1 comment

Comments

@SebRut
Copy link
Contributor

SebRut commented Jun 21, 2020

Describe the bug
The result of Jiffy().fromNow(...) is returning the default english texts if the locale is set to 'de_DE'.

To Reproduce

final locale = await findSystemLocale(); //returns 'de_DE'
await Jiffy.locale(locale);

final result = Jiffy().fromNow()

Expected behavior
result should display the relative time in german.

Additional context
I guess this occurs as relative time only checks for 'de`, 'deat' and 'dech', not 'dede'.

@jama5262
Copy link
Owner

@SebRut Indeed the de_DE is not supported, but as you mentioned in the issue
'de', 'deat' and 'dech' are only checked for relative time like fromNow() and from()

But if you would like de_DE to be supported, you can create a PR and add the locale to Jiffy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants