Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: External API #649

Open
rbndg opened this issue Jan 5, 2023 · 4 comments
Open

Feature Request: External API #649

rbndg opened this issue Jan 5, 2023 · 4 comments
Labels
enhancement New feature or request needs planning Talk to maintainers before working on this up for grabs Anyone can work on this

Comments

@rbndg
Copy link

rbndg commented Jan 5, 2023

Would be very nice if Polar had an API that can be used to create networks, create nodes, take them down.
Basically the features that are now possible via the GUI for managing the network, not for interacting with the actual nodes.

These will be used for integration testing

@rbndg rbndg added the enhancement New feature or request label Jan 5, 2023
@jamaljsr
Copy link
Owner

jamaljsr commented Jan 5, 2023

Thanks for the feedback. I've received a similar request some time ago. I think the right approach would be to split all of the docker & compose logic out to it's own NPM package which other apps can use to automate spinning up new networks. I like the idea, but this is a pretty big lift and not something I'd personally use, so I can't commit to working on it. I'll leave this issue open in case someone else would be interested in working on this.

@amovfx
Copy link
Contributor

amovfx commented Jan 6, 2023

I can see potential in this and have wanted the same feature as well. I really like that polar build's robust compose files.
I'm new to the codebase, and as @jamaljsr said, it's a big lift. I think this is something I would like to do after the Taro integration is complete if there aren't any pressing issues. I can't commit to it as I think it is something that is beyond my ability, but I'll investigate the idea in the future.

@jamaljsr jamaljsr added up for grabs Anyone can work on this needs planning Talk to maintainers before working on this labels Dec 19, 2023
@Muniru0
Copy link

Muniru0 commented Mar 1, 2024

@jamaljsr I will like to begin this. Since it is a huge deal I can't promise that I will complete it but I will definitely put in my all should I attempt it ?

@jamaljsr
Copy link
Owner

jamaljsr commented Mar 1, 2024

Hey @Muniru0, I would not suggest starting development on this until we have a deep dive discussion on exactly how to implement it. We have to draw a line between what code will live in the SDK versus what will remain in the Polar app. This is not a decision I'd want to make lightly because it will have pretty big consequences going forward.

Given the scale of this project, I don't recommend tackling this as a first time contributor. It would be better to tackle some smaller issues first to become more familiar with the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs planning Talk to maintainers before working on this up for grabs Anyone can work on this
Projects
None yet
Development

No branches or pull requests

4 participants