Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute libcif with Julia's artifacts system #7

Closed
Guillawme opened this issue Apr 28, 2021 · 4 comments
Closed

Distribute libcif with Julia's artifacts system #7

Guillawme opened this issue Apr 28, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@Guillawme
Copy link

Hello,

For systems that don't provide cifapi/libcif in their default package manager, it could be helpful to distribute it through Julia's artifacts system. Its license allows redistribution.

@jamesrhester jamesrhester added the enhancement New feature or request label Apr 29, 2021
@jamesrhester
Copy link
Owner

libcif requires both unicode libraries and sqlite libraries, so it is not as lightweight as it looks. Note that CrystalInfoFramework should be fully functional without libcif and the speed difference is less than it used to be, so an alternative plan might be to remove libcif completely.

@Guillawme
Copy link
Author

Ah, ok. I thought the difference was still relevant because using the native parser emits a warning. And I had not thought about the whole dependency chain, which indeed complicates things quite a bit.

@jamesrhester
Copy link
Owner

Should the native parser become the default, then there is no reason to emit a warning if it uses the Julia parser instead of the C parser.

@jamesrhester
Copy link
Owner

Commit e59b520 adds libcif support via cif_api_jll. It doesn't work for Windows, seems to be a problem with detecting end of file. Other platforms now do not need separate installation of cif_api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants