Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 was unexpected at this time #11

Open
fermin-silva opened this issue Sep 24, 2019 · 5 comments
Open

15 was unexpected at this time #11

fermin-silva opened this issue Sep 24, 2019 · 5 comments

Comments

@fermin-silva
Copy link

Hi,
im running build-win64-cpu+cuda.bat and its immediately failing with "15 was unexpected at this time"
I guess its probably coming from this line: https://github.com/jamriska/ebsynth/blob/master/vcvarsall.bat#L6
if %vsver% geq 15 (

Im running windows 10 64 bits.
Thanks

@OndrejTexler
Copy link

I did not test it, but if the line 6, or any line, of vcvarsall.bat is causing any problems. Try to locate vcvarsall.bat manually, in my case (of VS 2019) it is located at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build. And call it directly from https://github.com/jamriska/ebsynth/blob/master/build-win64-cpu%2Bcuda.bat, i.e., replace the line call vcvarsall.bat amd64 with call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" amd64

I hope it works :-)

@fermin-silva
Copy link
Author

Changed it but it didnt have any effect.
Apparently its because this variable is empty:
if %vsver% geq 15 (

If i run manually the command that sets this variable i get an empty output.
vswhere -latest -legacy -property installationVersion returns empty.

Maybe because i dont have some dev tools needed to compile c++ ? In MacOS I didnt have to install anything.
In any case, a simple "how to build" in the readme would be cool for the non programmers (or at least the non c++ programmers, like myself)

@OndrejTexler
Copy link

And you are not able to locate the vcvarsall.bat manually in your Visual Studio installation, right?

Maybe, you are missing some tools. VS with C++ build tools and Windows SDK should be only thing you need. Check whether your VS installation looks like this:
image

@fermin-silva
Copy link
Author

thanks for the support!
i dont have anything related to visual studio installed, i will probably end up downloading the precompiled version.

in any case, it would be nice to either have a how to build section in the readme or to make the build script check the dependencies and giving a nicer error message

@OndrejTexler
Copy link

Thank you for your suggestion. I agree that it would be nice to have a more robust build script or robust build tutorial, however, to make it really robust across all the MS Windows versions, VS versions, CUDA versions, etc. would be hard.

So this repo offers two "extreme" options, (1) user-friendly option of downloading the binaries, (2) advanced option for experienced C++ developers. And it would be hard to create something between these two "extreme" options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants