-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build process error and warning for 3.11.0rc1 #3373
Comments
I don't think they are related. I believe there's something wrong in two places.
|
For 1, the cleanest way would be to call gh release upload in the respective scripts instead of the hacky cross platform method we use currently: jamulus/.github/workflows/autobuild.yml Lines 434 to 436 in 97388ab
The issue is Windows: Otherwise, we could just upload every file from the deploy directory with a wildcard. For 2, further investigation is needed. |
I think for now we'll just split the release upload into two artifacts again. https://github.com/ann0see/jamulus/releases/tag/r0_3_10_0 |
Concerning 2, it seems to be comparable to actions/setup-node#362 Maybe we need to use a non standard location to put Qt to, or just delete the cache. |
OK, as it doesn't appear to have a discernable negative effect, I'm bumping the problem to after the release. |
Describe the bug
When editing the 3.11.0rc1 release, I noticed the following error:
Probably something in the deployment scripts.
There's also a warning relating to macOs in the output:
but may not be related.
To Reproduce
Cut a release candidate.
Expected behavior
No errors
Version of Jamulus
3.11.0rc1 release build.
The text was updated successfully, but these errors were encountered: