Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror (vertical flip) option #161

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

mryndzionek
Copy link
Contributor

@mryndzionek mryndzionek commented Dec 30, 2021

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

Added a function for mirroring/flipping the display. Not that elegant, but seems to be working (tested on one display so far). Let me know if this is acceptable.

@jamwaffles
Copy link
Collaborator

Thanks for the PR! I'll give this a test on my sample displays when I've got a spare minute :)

Copy link
Collaborator

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just some changes from my testing.

Also needs a changelog entry, something like:

### Added

- [#161](https://github.com/jamwaffles/ssd1306/pull/161) Added a `set_mirror` method to enable or disable display mirroring.

added after the Unreleased heading.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I didn't see your updates until now! Please throw me a comment for any future PRs so I don't forget :). Thanks for the fix!

@jamwaffles jamwaffles merged commit 01e8b5a into rust-embedded-community:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants