You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi i checked both previous and new code and i have a question. as i see, you move all viewmodels to ViewModelProviderFactory and remove them from modules. Although you mention new OpenSourceViewModel(dataManager,schedulerProvider); and new BlogViewModel(dataManager,schedulerProvider); in ViewModelProviderFactory, you also provide them in OpenSourceFragmentModule and BlogFragmentModule. why did you do this ?
thanks
The text was updated successfully, but these errors were encountered:
hey,
Thanks for pointing it out.
This looks like a mistake and we have rectified it and it will be available soon in the master branch.
Reason being , now all the VM creation is delegated to VMFactory and hence there should not be any VM creation from any of the modules.
hi i checked both previous and new code and i have a question. as i see, you move all viewmodels to ViewModelProviderFactory and remove them from modules. Although you mention new OpenSourceViewModel(dataManager,schedulerProvider); and new BlogViewModel(dataManager,schedulerProvider); in ViewModelProviderFactory, you also provide them in OpenSourceFragmentModule and BlogFragmentModule. why did you do this ?
thanks
The text was updated successfully, but these errors were encountered: