Current implementation of dumping arguments when mathod not match kills phpunit/php/everything

[jasir]

After couple of hours checking what is wrong (cpu high, everything freezed) I have found that implementation of throwing exception when method is wrong. Here is my (WIP) proposal - move the responsibility to Tracy.

Also there are some improvements with text of exception (see commit log).

jasir@04980a1

[janmarek]

I don't think that mockista should be dependent on Tracy just because of better exception message. Maybe we should create very simple dumper which would dump ints, strings, bools etc and print the type of other values.

[jasir]

Yes. That is why I did not open a pull request, just an discussion. I have thought maybe about "if tracy is present", use it, otherwise use something simple. But something different what there is in place now, which really kills everything.

[jasir]

Just for some impression, this is how output looks like now. Personally, I like it very much:

Unexpected call in mock eventDispatcher::dispatch(), none of 1 method(s) call candidates matched by arguments. Called with (2) arguments:
Parameter #0:"cms.cache.cleaned" (17)
Parameter #1:DNB\Events\Event #9f61
   subject private => stdClass #bef1
   |  data => stdClass #4cfb
   |  |  key => 666
   data private => NULL
   result private => NULL
   isResultSet private => FALSE
   propagationStopped private => FALSE
   dispatcher private => NULL
   name private => NULL
C:\Work\projects\cms\vendor\janmarek\mockista\Mockista\Mock.php:97
C:\Work\projects\cms\vendor\janmarek\mockista\Mockista\Mock.php:127
C:\Work\projects\cms\app\CMS\CacheManager.php:41
C:\Work\projects\cms\app\CMS\CacheManager.php:41
C:\Work\projects\cms\tests\tests\app\CMS\CacheManagerTest.php:50

[jasir]

What about this quick hack? Tracy\Dumper is used only if present (class_exists). It can be extended to other frameworks...

jasir@77d7f77

[MartinMystikJonas]

We just found out this problem results in false pass tests. In some cases var_dump of complex object structure kill php with exit code 0. There fore Nette tester thinks test passed.

I think we shoud:
a) use this solution
b) if dependency on Tracy have to be omitted then implement custom dumping

If opton b) would be preferred I'm willing to create PR. But in current state Mockista is unusable in about 50% of our tests.

[janmarek]

I think you can prepare PR which uses Tracy\Dumper::toText for compare the objects.