Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal window uses icon font as font family #70

Closed
billerickson opened this issue Oct 15, 2016 · 1 comment
Closed

Modal window uses icon font as font family #70

billerickson opened this issue Oct 15, 2016 · 1 comment
Labels

Comments

@billerickson
Copy link
Collaborator

billerickson commented Oct 15, 2016

Summary:
Currently the modal window classes are all easc-. So are our icons. This part of our stylesheet is forcing the 'easc' font for all classes starting with easc-.

Issues:

  • Modal window does not match the theme's general style guide
  • It's difficult to correct the styles due to our use of !important

Solution:
We either need to change the icon classes to easc-icon-, or change modal window classes to ea-share-count-modal-. Neither is backwards compatible. Personally I think changing the icon class names will be best, as those who modify the icons will either

  • Replace the current icons with their own, in which case this doesn't matter
  • Be targeting the generic <i> element, rather than using the class name (ex: easc-print).

I'd like to hear feedback on this change before making it.

@billerickson
Copy link
Collaborator Author

Another option would be to specifically target the icon classes, rather than selecting all classes that start with 'easc-'. That would mean we don't have to change any class names, would not cause any BC issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant