Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useLayoutEffect is never used in React Native #2011

Open
aleclarson opened this issue Nov 10, 2019 · 0 comments
Open

useLayoutEffect is never used in React Native #2011

aleclarson opened this issue Nov 10, 2019 · 0 comments
Labels
Focus: React-Native stale Type: Enhancement

Comments

@aleclarson
Copy link

aleclarson commented Nov 10, 2019 •
edited
Loading

🐛 Bug report

Current Behavior

The implementation of useIsomorphicLayoutEffect leads to useEffect being used in React Native where useLayoutEffect is intended.

More info here: reduxjs/react-redux#1444

Expected behavior

Formik should be calling useLayoutEffect in React Native.

Reproducible example

None yet, as I'm not sure how this bug affects Formik specifically.

Suggested solution(s)

Copy the solution from reduxjs/react-redux#1444 or use react-layout-effect to share code with other libraries (eg: react-spring will be using it).

If you decide to use react-layout-effect, let me know and I'll add you as a maintainer.

Your environment

N/A, all versions affected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus: React-Native stale Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleclarson @jaredpalmer