-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken build with tsdx build --format es
#114
Comments
The root issue appears to be if you exclude Excluding |
would also be useful |
@techniq it sounds like you're pretty close to a solution, want to propose a fix? |
Seems like a straight forward fix. Can someone open a PR? |
@sw-yx @jaredpalmer I don't have time right now (trying to hammer out some items before going on vacation -- just went went form 27% to 99% Typescript in a project and having to update a lot of my components accordingly, along with providing actual features). If it's still open in a few weeks I can take a stab at it. My workaround is getting me by for now. |
haha enjoy your vacation |
This can be closed as well, per #128 getting merged. |
Current Behavior
In an attempt to speed up my builds (and not need the other formats), I attempted to only build for
es
by changing thebuild
script inpackage.json
totsdx build --format es
but in doing so, it fails withI thought this might be fixed by this commit in 0.5.10 but even on
0.5.11
it still shows the issue (I did a fresh project withnpx tsdx create tsdx-test
to verify it wasn't anything in my project specifically).Expected behavior
To be able to only build a specific format (and possibly any other way so to optimize). My builds jumped from less than 2 minutes for the full pipeline (not just
npm run build
) to between 7-8 minutes after changing to tsdx (along with migrating to 99% typescript from ~30% prior). I could see having more Typescript code causing it to be a little slower, but not to this magnitude. I was only performing 1 build before, so I'm hoping going back to that will improve mytsdx
build times.Suggested solution(s)
I thought this commit was the fix, but not sure where the issue is now.
Your environment
0.5.11
3.1.6
Chrome
6.8.0
Mac
The text was updated successfully, but these errors were encountered: