Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Packages without Husky #419

Open
ncphillips opened this issue Jan 8, 2020 · 1 comment
Open

Create Packages without Husky #419

ncphillips opened this issue Jan 8, 2020 · 1 comment
Labels
kind: feature New feature or request

Comments

@ncphillips
Copy link
Contributor

ncphillips commented Jan 8, 2020

Current Behavior

New packages add husky hooks to the git repository.

Desired Behavior

Provide an optional flag to disable husky

Suggested Solution

tsdx create something-in-monorepo --no-hooks

Who does this impact? Who is this for?

This is for developers maintaining mono repos containing multiple packages. New hooks shouldn't be added when packages are created.

This is especially troublesome when switching between feature-branches where each branch might not have the same packages. The hooks fail and prevent committing, pushing, etc.

Describe alternatives you've considered

The alternative is to not use tsdx to create the new packages but to manually copy and paste existing packages in the monorepo.

Or I could manually open the commit hook files and delete the generated code

Additional context

We're using tsdx for some packages stored in the tinacms monorepo, which is managed using lerna.

@zhaoyao91
Copy link

this is needed for every mono repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants