Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioSourceInstance3dData::mFlags (possibly) uninitialized #361

Open
petrihakkinen opened this issue Jun 9, 2023 · 0 comments
Open

AudioSourceInstance3dData::mFlags (possibly) uninitialized #361

petrihakkinen opened this issue Jun 9, 2023 · 0 comments

Comments

@petrihakkinen
Copy link
Contributor

AudioSourceInstance3dData::init() does not copy the value of mFlags from AudioSource, so the member is uninitialized until Soloud::update3dAudio() is called for the first time. This causes the value of LISTENER_RELATIVE flag to be random when Soloud::update3dVoices() is called from play3d() and thus the initial overall volume of the sound can be computed incorrectly. This in turn causes random voice drops if the incorrectly computed overall volume falls under the inaudible threshold (0.01).

Note that I have verified this only with my forked version of Soloud which has some customizations so I'm not entirely sure if the problem happens with latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant