-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
### */ ### #1050
Comments
Nice catch. |
But how should this be fixed? Generate a compiler error if a block comment contains I'm guessing that if someone puts |
I agree, Trevor. Using the escape sequence for an asterisk is also a solution. Any reasons to pick one over the other? |
the reason he suggested using the escape for '/' becaue the * may be used in Markdown evaluation. |
Well, that's a good enough reason for me. Looks like we can just change line 433 of nodes.coffee to
|
Opened pull request #1053, fixing this issue. |
I'm afraid that translating to HTML entities isn't an acceptable solution. This is CoffeeScript to JavaScript -- not CoffeeScript to JS-that-might-be-displayed-within-HTML. If |
FYI, Coco went ahead and fixed the syntax to
|
I wouldn't be against changing coffee's multiline comments to use |
I'd be fine with that, too. Can't think of any reason to prefer |
Agreed. Heck - why not both!? AND I still like the proposition of converting */ to / - perhaps an optional modifier character after ### to mark the block for safe guarding?
|
The text was updated successfully, but these errors were encountered: