Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition function implemented #2850 #2897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohammadali-seifkashani

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.197% when pulling fc3d6a0 on mohammadali-seifkashani:master into c9b4b63 on jashkenas:master.

@jgonggrijp jgonggrijp linked an issue Dec 18, 2020 that may be closed by this pull request
@jgonggrijp jgonggrijp added contrib probably belongs in Underscore-contrib enhancement labels Dec 18, 2020
@jgonggrijp
Copy link
Collaborator

jgonggrijp commented Dec 18, 2020

Hey @mohammadali-seifkashani, thanks for this very interesting contribution! There will be some more work to do and I might decide to put this in Underscore-contrib instead, but that's fine, we can make this ride together.

As a first step, could you add a few more commits to do the following? Thanks in advance.

  • Rename the module to modules/transition.js (so without the leading _ in the name).
  • Make the export default.
  • List your function with the others in modules/index.js. I think it belongs in the utility section.
  • Add tests for your function in test/utility.js.

I'll do a more detailed code review after this.

@jgonggrijp jgonggrijp mentioned this pull request Dec 20, 2020
This was referenced Jan 11, 2021
@jgonggrijp jgonggrijp mentioned this pull request Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib probably belongs in Underscore-contrib enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _.toggle/_.transition/_.fsm to underscore
3 participants