Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: raw typed #1021

Merged
merged 10 commits into from
Aug 7, 2024
Merged

feat: raw typed #1021

merged 10 commits into from
Aug 7, 2024

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented Aug 6, 2024 •
edited
Loading

closes #854
closes #997

The intelisense for overloading is so poor that I decided to factor out rawString from raw and remove the other overload of raw(document, {...}).

TODO

  • fix type errors
  • write type tests for raw
  • write type tests for rawString
  • write docs

@jasonkuhrt jasonkuhrt marked this pull request as draft August 6, 2024 16:15
@jasonkuhrt jasonkuhrt marked this pull request as ready for review August 7, 2024 21:26
@jasonkuhrt jasonkuhrt merged commit ba48bf9 into main Aug 7, 2024
8 checks passed
@jasonkuhrt jasonkuhrt deleted the feat/raw-typed branch August 7, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support TypedDocumentString TypedDocumentNode support
1 participant
@jasonkuhrt