Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change event handlers registration style #474

Merged
merged 14 commits into from
Mar 11, 2023
Merged

fix: change event handlers registration style #474

merged 14 commits into from
Mar 11, 2023

Conversation

lyubo
Copy link
Contributor

@lyubo lyubo commented Mar 6, 2023

No description provided.

lyubo and others added 13 commits October 13, 2021 15:08
@lyubo lyubo mentioned this pull request Mar 6, 2023
Closed
@klujanrosas
Copy link

Is 62961fd actually the fix for this?

For some reason the old event handler registration style wasn't working for me but as soon as I changed it to addEventListener it all started working 🤷🏻‍♂️

@lyubo
Copy link
Contributor Author

lyubo commented Mar 7, 2023 •
edited
Loading

Is 62961fd actually the fix for this?

Hm, I planned a separate PR for that one. Hope that it will be accepted in this PR. Anyway, I'll post my comment in #432 thread.

@lyubo lyubo changed the title Add tests for GraphQLWebSocketClient fix: change event handlers registration style in WebSocket, ads test cases Mar 7, 2023
@lyubo lyubo changed the title fix: change event handlers registration style in WebSocket, ads test cases fix: change event handlers registration style, add test cases Mar 7, 2023
jasonkuhrt
jasonkuhrt approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try, ty!

@jasonkuhrt jasonkuhrt changed the title fix: change event handlers registration style, add test cases fix: change event handlers registration style Mar 11, 2023
@jasonkuhrt jasonkuhrt merged commit 8a98925 into graffle-js:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonkuhrt jasonkuhrt jasonkuhrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyubo @klujanrosas @jasonkuhrt