Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency typescript to v5 #480

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 16, 2023

closes #481

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) ^4.9.4 -> ^5.0.0 age adoption passing confidence

Release Notes

Microsoft/TypeScript

v5.0.2: TypeScript 5.0

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/typescript-5.x branch from 60c02dc to 3434e69 Compare March 29, 2023 14:58
@renovate
Copy link
Contributor Author

renovate bot commented Apr 4, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@jasonkuhrt
Copy link
Member

In working on this I had to ditch the types we copied over from DOM. It was a bad idea to take that approach. It is not sustainable. Especially now that Node 18+ has global web fetch APIs.

My solution has at least one breaking change for TS users which is that the consumer must now put "lib": ["DOM", "DOM.Iterable", "ES2020”], into their tsconfig.json.

I read this issue DefinitelyTyped/DefinitelyTyped#60924 while solving this. I would consdier that issuse an upstream issue that should be resolved instead of me trying to fight this huge battle alone here on this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript 5.0.2 complains about AbortSignal structure (works fine with TS 4.9.5)
1 participant