Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 0.5.0 release, otherwise bower can't find it. #14

Closed
abuiles opened this issue Jul 28, 2015 · 12 comments
Closed

Tag 0.5.0 release, otherwise bower can't find it. #14

abuiles opened this issue Jul 28, 2015 · 12 comments

Comments

@abuiles
Copy link
Contributor

abuiles commented Jul 28, 2015

No description provided.

@jasonmit
Copy link
Owner

This is now an ember-addon and should be installed through npm.

@abuiles
Copy link
Contributor Author

abuiles commented Jul 28, 2015

I got confused because the installer was adding this to my bower.

Anyways, I'm trying to use moment 2.10.5 seems like adding it to the package doesn't do the trick?

@abuiles
Copy link
Contributor Author

abuiles commented Jul 28, 2015

Probably you can remove moment from dependencies and add it via install ?

@jasonmit
Copy link
Owner

Moment is an npm dep as well, moment time zone is a bower dep and brings in moment with it. I'll try and see about bringing moment time zone in as an npm dep as well

@abuiles
Copy link
Contributor Author

abuiles commented Jul 28, 2015

cool, I'm experimenting in my own fork and doing this abuiles@a332ae4 works perfect for the scenario I'm tryng to cover. (maybe it might need to go in devDependencies)

Also it looks like the treeForApp is not being called when doing ember test, I keep getting

Error: Could not find module `ember-moment/computeds/moment` imported from `garaje/components/plan-ledger`

@abuiles
Copy link
Contributor Author

abuiles commented Jul 28, 2015

oh, treeForApp is being called. Still trying to figure why is this issue appearing while in the browser it works fine.

@jasonmit
Copy link
Owner

Error: Could not find module ember-moment/computeds/moment imported from garaje/components/plan-ledger

Can you post your project or reproduce this in an isolated app?

@jasonmit
Copy link
Owner

414d593

@abuiles
Copy link
Contributor Author

abuiles commented Jul 28, 2015

@jasonmit ok, so the issue with the import seems to be only in my project, I didn't get the issue in a clean project. thanks!

@abuiles
Copy link
Contributor Author

abuiles commented Jul 28, 2015

@jasonmit

414d593

Why don't you leave it in package.json? just add it to the package.json in the after install?

@abuiles
Copy link
Contributor Author

abuiles commented Jul 28, 2015

the idea down the road is to kill bower, so that could be better too.

@jasonmit
Copy link
Owner

@abuiles because it's already being pulled in via bower as a dep of moment-timezone, so might as well use that instead of pulling it in twice once via bower and once via npm.

I can't use the moment-timezone package over npm because it does not provide builds, it just provides one dist which isn't optimal in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants