Clean up forked threads #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismwendt
force-pushed
the
thread-cleanup
branch
from
7bc8f69
to
2c9f501
Compare
chrismwendt
force-pushed
the
thread-cleanup
branch
from
2c9f501
to
c619e36
Compare
chrismwendt
force-pushed
the
thread-cleanup
branch
from
c619e36
to
26602c0
Compare
chrismwendt
force-pushed
the
thread-cleanup
branch
from
ebfa0a6
to
124c4e9
Compare
|
@jaspervdj this can be merged as it does indeed fail to close the thread if killer is not installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
runServerwould not kill the threads it forked. Namely, it would lose track of theappAsyncs.After this change,
runServerwill kill all threads it forks.This modifies code created in #199 cc @jaspervdj