Add ping-pong implementation that handles stale connections. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
force-pushed
the
ping-pong
branch
from
e6f047d
to
2f9f180
Compare
domenkozar
changed the title
domenkozar
force-pushed
the
ping-pong
branch
2 times, most recently
from
f22f55e
to
242fa79
Compare
domenkozar
changed the title
domenkozar
force-pushed
the
ping-pong
branch
from
242fa79
to
ae484a7
Compare
jaspervdj
approved these changes
Dec 26, 2023
| @@ -252,6 +255,7 @@ data Connection = Connection | |||
| { connectionOptions :: !ConnectionOptions | |||
| , connectionType :: !ConnectionType | |||
| , connectionProtocol :: !Protocol | |||
| , connectionHeartbeat :: !(MVar ()) | |||
There was a problem hiding this comment.
I would add a comment to the field explaining how this is used (or refer to the PingPong module).
| -- for example N/2. | ||
| data PingPongOptions = PingPongOptions { | ||
| pingInterval :: Int, -- ^ Interval in seconds | ||
| pongTimeout :: Int, -- ^ Timeout in seconds |
There was a problem hiding this comment.
I only noticed this because of the comment on the other PR; but I guess it would be more consistent if the library uses microseconds for time everywhere rather than mixed units?
There was a problem hiding this comment.
Given that the other Ping utilities use seconds, maybe it's better we just use seconds for the connection timeout as well. I'll add it to the other PR.
Because the Server used only pong implementation it's not possible to keep backwards compatibility with the new implementation that also does pinging.
domenkozar
force-pushed
the
ping-pong
branch
from
ae484a7
to
24d7f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Server used only pong implementation it's not possible to keep backwards compatibility with the new implementation that also does pinging.
Fixes #159
cc @jaspervdj