Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CI green (address pylint) #28

Closed
jatkinson1000 opened this issue Mar 21, 2023 · 1 comment · Fixed by #44
Closed

Get CI green (address pylint) #28

jatkinson1000 opened this issue Mar 21, 2023 · 1 comment · Fixed by #44

Comments

@jatkinson1000
Copy link
Owner

jatkinson1000 commented Mar 21, 2023

Currently the CI checks fail for pylint (added in #25 ).
Whilst some of these are legitimate to ignore (variable names) others hint at the need for some refactoring and will be addressed in some other issues.

After looking at these we should then return to place any ignores that we feel are legitimately warranted.

Issues to tackle that will help address this:

@jatkinson1000
Copy link
Owner Author

Short variable name warnings will be dealt with in an upcoming release of PyLint: pylint-dev/pylint#8813

@jatkinson1000 jatkinson1000 mentioned this issue Sep 2, 2023
@jatkinson1000 jatkinson1000 linked a pull request Sep 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant