Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNA no longer buildable with a target JDK of 1.6 #1025

Closed
lwahonen opened this issue Oct 11, 2018 · 4 comments
Closed

JNA no longer buildable with a target JDK of 1.6 #1025

lwahonen opened this issue Oct 11, 2018 · 4 comments

Comments

@lwahonen
Copy link

Hi,

Commit 267bbce calls the parameterCount method, which has been marked as >= 1.8.

Looks like this is easily patched via m.getParameterTypes().length, but the whole VARIANT is full of magic so I'm afraid of breaking something here.

Cheers,
Will

@matthiasblaesing
Copy link
Member

Good catch - the build produces bytecode that is compatible with a 1.6 VM, but the classpath is more problematic. We can't build against a JDK < 8 because for support for JDK >= 9 we need annotations introduced with JDK 8.

For the concrete problem, I agree with your solution.

@matthiasblaesing
Copy link
Member

@lwahonen could you please have a look at: PR #1026? That PR fixes the incompatibilities and introduces animal-sniffer to prevent regressions. Does that look good to you?

@lwahonen
Copy link
Author

Looks great to me! I'm not very familiar with animal-sniffer, but looks like it can't be worse than nothing.

@matthiasblaesing
Copy link
Member

Thanks for checking. I merged the changeset to master and will give it a few days to settle. I want to see if other problems crop up and if not, I'll cut a release from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants