WinXP Compatibility for PdhUtil#PdhLookupPerfNameByIndex #1053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the fix in #1052 worked on one XP system it did not work on another. Not sure if it was character encoding or bitness or something else, but the docs were also unclear as to the behavior of the buffer length value:
And also suggesting error code response varied:
This second fix should work and passes tests on a few different XP VMs. Vista+ does the "pass null, get size, get result" calls. For XP the buffer is incremented until it succeeds so we don't have to rely on the returned size.