-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix native conversion for empty CFStringRef. #1275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix and the updated test case. One typo in the changelog, and can you squash the commits please?
dblock
reviewed
Nov 25, 2020
contrib/platform/src/com/sun/jna/platform/mac/CoreFoundation.java
Outdated
Show resolved
Hide resolved
dbwiddis
reviewed
Nov 25, 2020
Looks great to me. I'll merge after CI tests pass. |
Tks @dbwiddis , looking forward to contribute with some macOs binds when I consider it more stable. |
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in con.sun.jna.Memory(long) constructor: java.lang.IllegalArgumentException: Allocation size must be greater than zero
tresf
pushed a commit
to tresf/jna
that referenced
this pull request
Dec 1, 2020
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in con.sun.jna.Memory(long) constructor: java.lang.IllegalArgumentException: Allocation size must be greater than zero
dbwiddis
pushed a commit
to dbwiddis/jna
that referenced
this pull request
Jan 29, 2021
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in con.sun.jna.Memory(long) constructor: java.lang.IllegalArgumentException: Allocation size must be greater than zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to convert a CFStringRef with empty string (char[0]) an Exception is throws in com.sun.jna.Memory(long) constructor:
java.lang.IllegalArgumentException: Allocation size must be greater than zero
Issue: #1274