Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilingual support of Kernel32Util.formatMessage() #1480

Closed
overpathz opened this issue Nov 18, 2022 · 2 comments
Closed

Multilingual support of Kernel32Util.formatMessage() #1480

overpathz opened this issue Nov 18, 2022 · 2 comments
Labels
feature request

Comments

@overpathz
Copy link
Contributor

jna/contrib/platform/src/com/sun/jna/platform/win32/Kernel32Util.java

Line 196 in 529b716

0, // TODO: // MAKELANGID(LANG_NEUTRAL,SUBLANG_DEFAULT)

Hi,
I am making a multilingual application and I have a case that Kernel32Util.getLastErrorMessage() messages are being written to the log in user-local language instead of English.

Sure, I can fix this problem locally but I would like to contribute a fix -- would you accept a PR fixing that TODO?

Thank You
Kind Regards,
Oleksandr Klymenko
@dbwiddis
Copy link
Contributor

Sure, I can fix this problem locally but I would like to contribute a fix

Yes please!

@overpathz overpathz mentioned this issue Dec 1, 2022
Closed
@matthiasblaesing
Copy link
Member

Fixed via 49d80ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthiasblaesing @dbwiddis @overpathz