Appveyor CI is broken

[dbwiddis]

Provide complete information about the problem

1. Version of JNA and related jars: master branch
2. Version and vendor of the java virtual machine: AppVeyor runner
3. Operating system: Windows
4. System architecture (CPU type, bitness of the JVM): All configured types
5. Complete description of the problem

Appveyor builds have not been working since Dec 10, 2022. Current error on startup is

msbuild "C:\projects\jna-gsxuq\native\libffi\msvc_build\aarch64\Ffi_staticLib.sln" /verbosity:minimal /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
Microsoft (R) Build Engine version 14.0.2[5](https://ci.appveyor.com/project/dblock/jna-gsxuq/builds/45643112#L5)420.1
Copyright (C) Microsoft Corporation. All rights reserved.
C:\Program Files (x8[6](https://ci.appveyor.com/project/dblock/jna-gsxuq/builds/45643112#L6))\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.Cpp.Platform.targets(31,3): error MSB4019: The imported project "C:\Program Files (x[8](https://ci.appveyor.com/project/dblock/jna-gsxuq/builds/45643112#L8)6)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\ARM64\PlatformToolsets\v140\Toolset.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk. [C:\projects\jna-gsxuq\native\libffi\msvc_build\aarch64\Ffi_staticLib.vcxproj]

I don't have a Windows environment to test/debug, but I suspect the Appveyor conviguration is using VS Build 2015 or 2019, when the new runners are using VS Build 2022, so the V140 is now V170 (among other changes). This SO Post might be relevant.

This is likely an easy "update to latest version" fix for someone with a Windows machine.

6. Steps to reproduce

See https://ci.appveyor.com/project/dblock/jna-gsxuq/history

[dblock]

I suggest dropping AppVeyor for GHA that now supports Windows.

[matthiasblaesing]

Appveyor currently works and shows a real problem in the callback code (Segfaults in at least two places and I don't see why it happens).

As reference: https://ci.appveyor.com/project/matthiasblaesing/jna/build/job/cn7v77hhrl6y6g6a#L2207

    [junit] Testsuite: com.sun.jna.platform.win32.Advapi32Test
    [junit] #
    [junit] # A fatal error has been detected by the Java Runtime Environment:
    [junit] #
    [junit] #  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x000000005dddd78a, pid=984, tid=0x00000000000009bc
    [junit] #
    [junit] # JRE version: Java(TM) SE Runtime Environment (8.0_162-b12) (build 1.8.0_162-b12)
    [junit] # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.162-b12 mixed mode windows-amd64 compressed oops)
    [junit] # Problematic frame:
    [junit] # V  [jvm.dll+0x13d78a]
    [junit] #
    [junit] # Core dump written. Default location: C:\projects\jna\hs_err_pid984.mdmp
    [junit] #
    [junit] # An error report file with more information is saved as:
    [junit] # C:\projects\jna\hs_err_pid984.log
    [junit] #
    [junit] # If you would like to submit a bug report, please visit:
    [junit] #   http://bugreport.java.com/bugreport/crash.jsp
    [junit] #
    [junit] Testsuite: com.sun.jna.platform.win32.Advapi32Test
    [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
    [junit] 
    [junit] Testcase: com.sun.jna.platform.win32.Advapi32Test:testReadEncryptedFileRaw:	Caused an ERROR
    [junit] Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
    [junit] junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit.
    [junit] 
    [junit] 
    [junit] Test com.sun.jna.platform.win32.Advapi32Test FAILED (crashed)
    [junit] Testsuite: com.sun.jna.platform.win32.Advapi32UtilTest
    [junit] Tests run: 54, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.968 sec

[dbwiddis]

Appveyor currently works and shows a real problem

Ah, then the problem is that the badge on the home page links to the old @dblock setup and not the new location under @matthiasblaesing . Should probably revert my latest PR then (and fix the badge).

I suggest dropping AppVeyor for GHA that now supports Windows.

I tried setting up a windows GHA when we first migrated off Travis CI, and ran into blocking problems, and gave up.