Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Netapi32Util.getDomainTrusts() includes "empty" domain object #145

Merged
merged 3 commits into from
Oct 24, 2012

Conversation

aikidojohn
Copy link
Contributor

After creating the DS_DOMAIN_TRUST structure from memory, read() was not being called to set the field values for the first array element from memory.

I'm adding a call to read() in the DS_DOMAIN_TRUST(Pointer p) constructor since this appears to be the convention.

@dblock
Copy link
Member

dblock commented Oct 24, 2012

Can you please add an entry to CHANGES under a new 3.5.1 section describing the fix, similar to the others.

Also, maybe there's a way to extend the unit test to actually fail without this fix?

Appreciated.

…eclaration. This should fix the getDC method and unit test
@aikidojohn
Copy link
Contributor Author

The unit test was actually failing if you run it in a domain.

@aikidojohn
Copy link
Contributor Author

So, since I not 100% familiar with git yet, I pushed another bugfix to my master branch, so I described both in CHANGES.md. I can do something different if you want - I'm just not sure how to do it.

@dblock
Copy link
Member

dblock commented Oct 24, 2012

Very good, thank you. For next time just start with a branch so that you have a topic branch. It's a bit cleaner to keep master exactly in the state upstream is.

dblock added a commit that referenced this pull request Oct 24, 2012
Fixing Netapi32Util.getDomainTrusts() includes "empty" domain object
@dblock dblock merged commit fffc3f0 into java-native-access:master Oct 24, 2012
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
Motivation:

dd211ef changed the version of quiche we compile against and correctly used --features ffi for macOS. Unfortunally we missed to do the same for linux

Modifications:

Add --features ffi on linux as well when building

Result:

No more "undefined symbol" errors on linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants