New ant target for installing JNA artifacts in local m2-repository #644
Conversation
| @@ -1176,6 +1176,24 @@ osname=macosx;processor=x86;processor=x86-64;processor=ppc | |||
| </subant> | |||
| </target> | |||
|
|
|||
| <target name="deploy-local" depends="dist" description="deploy snapshot version to local repository"> | |||
There was a problem hiding this comment.
Maybe change the target name to install-local, and description: install snapshot ..... The maven term for this action is install, so I think this change would be less confusing.
There was a problem hiding this comment.
I'd suggest target name "install" (matches maven goal "install:install", which installs artifacts into the local repository, the installation into a remote repository is "deploy:deploy").
And for the description: "Install jna and jna-platform artifacts into local maven repository". There is nothing preventing the user to run install on a non-snapshot build.
|
Apart from the nitpick I like this! |
SevenOf9Sleeper
force-pushed
the
ant_local_maven_deploy
branch
from
7516bbc
to
34e45bd
Compare
|
I have changed name and description. You are right: "install" is more suitable. |
|
Looks good. Could you also add a short blurb to the CHANGES.md file? On a separate, but related note, some work has begun to create a "maven" build. See the files in the "parent" folder for details. It's just the "native" bits right now. |
SevenOf9Sleeper
force-pushed
the
ant_local_maven_deploy
branch
from
34e45bd
to
40e3cf0
Compare
SevenOf9Sleeper
force-pushed
the
ant_local_maven_deploy
branch
from
40e3cf0
to
f5f5f4d
Compare
|
Build works correctly on linux and windows, with spaces in path and without. Thanks! 👍 |
…a-native-access#644) Motivation: We did fire the SniCompletionEvent only once we were done with the handshake which is not really the correct time to do this. We should fire the event as soon as we were able to process the client hello and selected the hostname. Modifications: - Fire the event as soon as we select the hostname Result: Fire the event at the correct time
I have missed a simple way to activate my recently built jna artifacts so I can use them in other maven projects. So I would appreciate it to add an ant target for doing so after the "dist" build