Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JPMS for javalin-ssl #84

Closed
bjorndarri opened this issue Jun 2, 2023 · 3 comments
Closed

Enable JPMS for javalin-ssl #84

bjorndarri opened this issue Jun 2, 2023 · 3 comments

Comments

@bjorndarri
Copy link
Contributor

Seeing that Javalin Core just got JPMS enabled (Add JPMS to Core Javalin) it would be great if the same could be done for this library.

The sslcontext-kickstart library just got modularised (Add support for java modules) in version 8.0.0, with minor breaking changes in package names.

I've implemented this in the modules branch of a fork of mine.

I'm not planning on creating a pull-request, since this change seems quite trivial (and I had to add a jetbrains.annotations dependency, which makes me think I'm misundarstanding something 😄), so just take this as an example of how this could be done.

@zugazagoitia
Copy link
Member

Please do open the PR and I'll look at it by the end of the week!

@bjorndarri
Copy link
Contributor Author

Here you go: #85

@zugazagoitia
Copy link
Member

Closed by #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants