Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download of actress images from JavBus fails #316

Closed
mimiku0 opened this issue Nov 7, 2021 · 1 comment
Closed

Download of actress images from JavBus fails #316

mimiku0 opened this issue Nov 7, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mimiku0
Copy link

mimiku0 commented Nov 7, 2021

Expected Behavior

Actress Images get downloaded successfully from JavBus

Current Behavior

Actress Images with Japanese characters fail with a message like:
Get-RunspaceData: [...]\PowerShell\Modules\Javinizer\2.5.9\Public\Invoke-JVParallel.ps1:568
Line |
568 | Get-RunspaceData -Wait
| ~~~~~~~~~~~~~~~~~~~~~~
| Exception calling "EndInvoke" with "1" argument(s): "The running command stopped because the
| preference variable "ErrorActionPreference" or common parameter is set to Stop: [n0001] [Set-JVMovie]
| Error occurred when creating actress image files: Exception calling "DownloadFile" with "2"
| argument(s): "Could not find file 'C:\imgs\actress\4l3.jpg'.""

Steps to Reproduce (for bugs)

  • Option scraper.movie.javbusja": true
  • Option "sort.download.actressimg": true
  • e.g. use Javinizer -strict for N0001
  • The address of for the actress thumb will be "/imgs/actress/4l3.jpg" (while it would normally start with "https://")
  • The relative path cannot be handled and the download fails

Issue Fix:
In file Scraper.Javbus.ps1 in line 279 changing
ThumbUrl = $thumbUrl
to
ThumbUrl = 'https://www.javbus.com' + $thumbUrl
(analog to the Else case (no Japanese characters) in line 314) fixes the issue.

Your Environment

  • Module version used: 2.5.9
  • Operating System and PowerShell version: 7.0.4.0
@jvlflame
Copy link
Collaborator

Thanks for the detailed reproduction report and fix.
I'll test this out and push out a new version with a fix when I have the chance.

@jvlflame jvlflame added the bug Something isn't working label Nov 10, 2021
@jvlflame jvlflame self-assigned this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants