Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approval status should be kept as string instead of ordinal number in DB #109

Closed
javrasya opened this issue Oct 20, 2019 · 0 comments
Closed

Approval status should be kept as string instead of ordinal number in DB #109

javrasya opened this issue Oct 20, 2019 · 0 comments
Labels
enhancement
Milestone
3.0.0

Comments

@javrasya
Copy link
Owner

Acceptance Criteria:

  • Turn status column into a string enumeration instead of a number to make it more readable in the DB and avoid mistakenly changed ordinality.
  • Write a safe custom migration to migrate the existing integer status column to the new string status column not to break the clients.
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
1dbe56e 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
5515f25 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
2549945 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
f8b92d1 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
65fae9e 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
8b84a8e 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
c796301 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
08a544e 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
2170335 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
370e8ce 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
8235401 
…tring enumeration
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Fix migration test
ddde44e
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#109] Skip migrating status test if django version is greater than 2
72c61c6
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya
[#108, #109] Update changelog
376ec7e
@javrasya javrasya added this to the 2.1.0 milestone Oct 28, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
5b490d1 
…tring enumeration
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
53820d8 
…tring enumeration
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Fix migration test
c75793e
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Skip migrating status test if django version is greater than 2
6019b83
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#108, #109] Update changelog
7b77d56
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
fdbd9d8 
…tring enumeration
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Turn approval status column from to be nteger enumeration to s…
67e07b3 
…tring enumeration
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Fix migration test
3ee2951
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#109] Skip migrating status test if django version is greater than 2
d8de17f
javrasya added a commit that referenced this issue Nov 17, 2019
@javrasya
[#108, #109] Update changelog
7cd5080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@javrasya