-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds VALIDATE_USER setting config, if False then don't check email in User model #370
base: master
Are you sure you want to change the base?
Conversation
Needed for application that don't have website based interface.
Adds logic to bypass validation error for user model user.
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 86.02% 85.88% -0.14%
==========================================
Files 16 16
Lines 1302 1311 +9
Branches 137 139 +2
==========================================
+ Hits 1120 1126 +6
- Misses 135 136 +1
- Partials 47 49 +2
Continue to review full report at Codecov.
|
"account on this site. Please log in as that user " | ||
"and try again." | ||
) % {'email': email}) | ||
if User.objects.filter(email__exact=email).exists(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be email__iexact? Because "[email protected]" and "[email protected]' would be the same user.
Any update on this PR? I would greatly like to use this feature. My newsletter signup is only public-facing. So I want to require emails to always be inputted and disable the validation to not leak user data per this issue: #183 |
I need this PR too as I also do not use the django user system. |
Need this functionality for the applications that don't have a web-based interface for normal users.
if NEWSLETTER_VALIDATE_USER is false in settings.py then it will not check for email in the User model.
fixes #369