Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/revisit codecov integration/config #135

Open
blueyed opened this issue Mar 4, 2019 · 3 comments
Open

Update/revisit codecov integration/config #135

blueyed opened this issue Mar 4, 2019 · 3 comments

Comments

@blueyed
Copy link

blueyed commented Mar 4, 2019

In/for #8 apparently a yaml for the organization was created: https://codecov.io/account/gh/jazzband/yaml

I think we should use the new integration via https://github.com/apps/codecov/installations/new/permissions?target_id=15129049 instead, and remove the project config, as it seems to affect all projects, and overrides the default config.

But it might also make sense to set a default config here, given that most projects do not like codecov comments for example.

The following might be good, but includes comments:

coverage:
  status:
    project: yes
    patch: yes
    changes: yes

comment:
  layout: "header, diff, flags"
  behavior: default
  require_changes: no

Ref: https://docs.codecov.io/docs/codecov-yaml
Ref: https://docs.codecov.io/docs/pull-request-comments

@blueyed
Copy link
Author

blueyed commented Mar 4, 2019

Codecov is posting comments for PRs with jazzband/pip-tools however, which does not have a custom config (file or via the UI): jazzband/pip-tools#754 (comment)

Therefore it seems to use default settings for this there.

@jezdez
Copy link
Member

jezdez commented Mar 4, 2019

Yeah, I think since I've enabled the GitHub app for Codecov the old org wide settings simply don't make any sense anymore and the bot setting may even be ignored. Removing the org wide setting..

@jezdez
Copy link
Member

jezdez commented Mar 4, 2019

I'm not sure about the rest of the config above, would you mind commenting the code sample with what each does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants