bubble the spec up #7
Conversation
| ls\n | ||
|
|
||
| # response | ||
| # TODO: maybe include a varint number of protocols here ? |
There was a problem hiding this comment.
@whyrusleeping @jbenet this is something we never set in stone.
Should we include a varint at the beginning of a ls response with the number of protocols (length prefixed messages) that will come next, or a varint with the size of all of those protocols summed together?
There was a problem hiding this comment.
i think both: a varint of protocols and a varint of total size in bytes (the second is hard on dynamic systems, but may be fine and prevent attack on unsuspecting clients)
There was a problem hiding this comment.
i think the way I do it is a varint saying the entire size of the response
There was a problem hiding this comment.
Having only a varint with the number of protocols might make things simpler to parse, since we know the number of rounds to apply.
I'm not seeing any benefit from having another varint for the global size added to the first one.
There was a problem hiding this comment.
Thank you :)
Just to confirm, the will still be <> per protocol, correct?
(note: We've being including \n on the end of the protos https://github.com/diasdavid/js-multistream/blob/master/src/lib/interactive.js#L45)
There was a problem hiding this comment.
The current way I do the ls response is to send:
<varint length of entire response>
<varint protocol name length>/protocol/name<newline>
...
...
...
...
<newline>
There was a problem hiding this comment.
I am expanding the example to remove any kind of ambiguity. This is what Juan proposes:
<varint-total-response-size-in-bytes><varint-number-of-protocols>\n
<varint of (protocol length + newline)><protocol><newline>
<varint of (protocol length + newline)><protocol><newline>
...
<varint of (protocol length + newline)><protocol><newline>
@whyrusleeping sounds good?
There was a problem hiding this comment.
Can we have a verdict here? :)
There was a problem hiding this comment.
@diasdavid we settled this before -- #7 (comment) -- go-multistream needs to change
| < <varint-protocol-length-plus-new-line><protocol><newline> | ||
| # ... | ||
| < <varint-protocol-length-plus-new-line><protocol><newline> | ||
| ``` |
There was a problem hiding this comment.
I've added this example in detail to solve the ambiguity of the spec. @jbenet @whyrusleeping please confirm
|
hm..... not enough varints. |
|
Going to merge, woooo \o/ :D |
as suggested on #3 (comment)