Documentation examples on transaction management contains invalid code

[carlosmiranda]

In our documentation page http://jdbc.jcabi.com/example-transaction.html, we have the following example, which contains some invalid statements:

public class Main {
  public static void main(String[] args) {
    new JdbcSession(source)
      .autocommit(false)
      .sql("START TRANSACTION")
      .update() // Will not compile!
      .sql("DELETE FROM employee WHERE name = ?")
      .set("Jeff Lebowski")
      .update() // Ditto.
      .sql("INSERT INTO employee VALUES (?)")
      .set("Walter Sobchak")
      .insert(Outcome.VOID) // Neither will this.
      .commit();
  }
}

This is wrong because the method update and insert have signatures T update(Outcome<T>) and T insert(Outcome<T>). We should be referring to the execute() method instead, like so:

public class Main {
  public static void main(String[] args) {
    new JdbcSession(source)
      .autocommit(false)
      .sql("START TRANSACTION")
      .execute() // Now this will compile!
      .sql("DELETE FROM employee WHERE name = ?")
      .set("Jeff Lebowski")
      .execute() // Change it here, too
      .sql("INSERT INTO employee VALUES (?)")
      .set("Walter Sobchak")
      .execute() // And here.
      .commit();
  }
}

[dmarkov]

this task will get someone's attention soon

[dmarkov]

thanks for reporting! I topped your account for 15 mins, transaction 40726905

[dmarkov]

@darkled the task is for you now, follow these guidelines. Don't hesitate to ask any technical questions right here

Task's budget is 30 mins (see this for explanation)

[asaen]

@carlosmiranda @dmarkov please, pay your attention, that PR is sent, but it's acceptance is blocked by #33

[yegor256]

@dmarkov we're waiting for #33

[dmarkov]

@dmarkov we're waiting for #33

@yegor256 sure, let's wait for #33

[dmarkov]

I think we can continue, impediment #33 is closed

[asaen]

@carlosmiranda should be fixed within PR #32, please, check it and close the issue if it is done.

[carlosmiranda]

@darkled Indeed it's fixed, thank you. Closing now.

[dmarkov]

@darkled thank you, added 30 mins to your acc, payment num is 50573737... +30 added to your rating, current score is: +285