Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JdbcSession should close connection after execution #5

Closed
krzyk opened this issue Nov 1, 2013 · 4 comments
Closed

JdbcSession should close connection after execution #5

krzyk opened this issue Nov 1, 2013 · 4 comments
Labels

Comments

@krzyk
Copy link

krzyk commented Nov 1, 2013

Leaving a stale open connection leads to problems with connection pools (they don't know if the connection is still used).
JdbcSession should either have an explicit close connection in finally clause in run method or have a seperate public close method that will close it.

@yegor256
Copy link
Member

yegor256 commented Nov 2, 2013

thanks for reporting!

@dmarkov dmarkov reopened this Dec 9, 2013
@dmarkov
Copy link

dmarkov commented Dec 9, 2013

@yegor256 please don't close the issue, ask @krzyk to do this instead, since he is the author of it

@yegor256
Copy link
Member

yegor256 commented Dec 9, 2013

@krzyk could you please close it if the problem is fixed

@krzyk
Copy link
Author

krzyk commented Dec 10, 2013

Yes, it is fixed

@krzyk krzyk closed this as completed Dec 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants