Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing invitation uses wrong method #3638

Closed
roberta-pavel opened this issue Oct 8, 2024 · 1 comment · Fixed by #3639
Closed

Removing invitation uses wrong method #3638

roberta-pavel opened this issue Oct 8, 2024 · 1 comment · Fixed by #3639
Labels
released This issue/pull request has been released. type:bug Changes fix a minor bug

Comments

@roberta-pavel
Copy link
Contributor

roberta-pavel commented Oct 8, 2024

Description

  • Node.js version: 18.20.4
  • Gitbeaker version: 40.4.0
  • Gitbeaker release (cli, rest, core, requester-utils): core
  • OS & version: Mac

Removing method for invitations uses put method instead of delete

Steps to reproduce

const gitlabService = new Gitlab({
  host: HOST,
  token: TOKEN,
});

await gitlabService.GroupInvitations.remove(someId, someEmail)

Expected behaviour

Invitation gets removed

Actual behaviour

Error "Bad request" because the method is not correct

Possible fixes

Update method for remove from put to del here

Open pull request: #3639

Checklist

  • [ x ] I have checked that this is not a duplicate issue.
  • [ x ] I have read the documentation.
@jdalrymple
Copy link
Owner

🚀 Issue was released in 40.5.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. type:bug Changes fix a minor bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants