Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResouceDiscussions.addNote is wrong #342

Closed
ianliu opened this issue Jun 9, 2019 · 3 comments · Fixed by #345
Closed

ResouceDiscussions.addNote is wrong #342

ianliu opened this issue Jun 9, 2019 · 3 comments · Fixed by #345
Milestone
6.x.x

Comments

@ianliu
Copy link

ianliu commented Jun 9, 2019

Description
By inspecting the Gitlab API page Discussions | Add note to existing issue discussion, I can see that the method ResourceDiscussions.addNote isn't right. It is calling a PUT, while the endpoint expects a POST.

Also, the Documentation isn't very clear, but I think you can call it in the following two ways:

  • POST /projects/:id/issues/:issue_iid/discussions/:discussion_id/notes to append a new note into a discussion;
  • POST /projects/:id/issues/:issue_iid/discussions/:note_id/notes to "transform" a note into a discussion, whilst appending a new note into it.
@jdalrymple
Copy link
Owner

Ill fix this in the next day! Sorry about that :s

jdalrymple added a commit that referenced this issue Jun 10, 2019
@jdalrymple
fix: Resource Discussion API was using the incorrect url to add a note
10cf3aa 
fixes: #342
@jdalrymple jdalrymple added the Bug label Jun 10, 2019
@jdalrymple jdalrymple added this to the 6.x.x milestone Jun 10, 2019
@jdalrymple jdalrymple mentioned this issue Jun 10, 2019
Merged
jdalrymple added a commit that referenced this issue Jun 10, 2019
@jdalrymple
fix: Resource Discussion API was using the incorrect url to add a note (
c6ff86d 
#345)

fixes: #342
jdalrymple pushed a commit that referenced this issue Jun 10, 2019
@semantic-release-bot
chore(release): 6.3.1 [skip ci]
51e99d0 
## [6.3.1](6.3.0...6.3.1) (2019-06-10)

### Bug Fixes

* Resource Discussion API was using the incorrect url to add a note ([#345](#345)) ([c6ff86d](c6ff86d)), closes [#342](#342)
@jdalrymple
Copy link
Owner

🎉 This issue has been resolved in version 6.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ianliu
Copy link
Author

ianliu commented Jun 20, 2019

@jdalrymple thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.x.x
Development

Successfully merging a pull request may close this issue.

fix: Resource Discussion API was using the incorrect url to add a note jdalrymple/gitbeaker
2 participants
@ianliu @jdalrymple