Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users.session throws 404 #404

Closed
DanielRuf opened this issue Aug 5, 2019 · 3 comments · Fixed by #405
Closed

Users.session throws 404 #404

DanielRuf opened this issue Aug 5, 2019 · 3 comments · Fixed by #405

Comments

@DanielRuf
Copy link
Contributor

Description
https://github.com/jdalrymple/node-gitlab/blob/226b11f48c1f5041de11d042708df9c3ed229c6a/src/services/Users.ts#L51

await api.Users.session(user, pass) throws a 404

https://gitlab.com/api/v4/session

Steps to reproduce

Expected behaviour

Actual behaviour

Possible fixes

@jdalrymple jdalrymple added the Bug label Aug 6, 2019
@jdalrymple
Copy link
Owner

jdalrymple commented Aug 6, 2019

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md#1020-2017-11-22

Apparently the Session API was removed a while back in v 10.2.0. I could add an error message to make that clearer? but its been like this for a couple years now so i'm not sure its required.

@jdalrymple
Copy link
Owner

🎉 This issue has been resolved in version 10.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

jdalrymple pushed a commit that referenced this issue Aug 6, 2019
## [10.0.3](10.0.2...10.0.3) (2019-08-06)

### Bug Fixes

* Removing deprecated Session endpoint (since GitLab 10.2.0) ([fe720d8](fe720d8)), closes [#404](#404)
@jdalrymple
Copy link
Owner

🎉 This issue has been resolved in version 10.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants