Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks Arrow functions #104

Closed
tp opened this issue Mar 25, 2014 · 7 comments · Fixed by #109
Closed

Breaks Arrow functions #104

tp opened this issue Mar 25, 2014 · 7 comments · Fixed by #109

Comments

@tp
Copy link

tp commented Mar 25, 2014

Before format:
x => x.id

After format:
x = > x.id

I would not expect any changes.

@tp
Copy link
Author

tp commented Mar 25, 2014

Or is it enough that it is tracked here: beautifier/js-beautify#402 ?

@jdavisclark
Copy link
Owner

the issue with js-beautify is enough. but, It's always good to make an issue here and reference the one upstream. It gives the upstream issue a little more visibility (the main js-beautify maintainer checks in here frequently)

@tp
Copy link
Author

tp commented Mar 28, 2014

Nice, this is already fixed upstream :)

@schickling
Copy link

When will this be released in this package?

@bitwiseman
Copy link
Collaborator

As soon as I have a little spare time. Maybe this weekend.

@jdavisclark
Copy link
Owner

@schickling I would prefer to wait until it's in an actual release of js-beautify.

But, since there is pretty good test coverage in js-beautify now, we can re-evaluate on the chance that @bitwiseman doesn't get some free time soon.

@bitwiseman
Copy link
Collaborator

Okay, v1.5.1 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants