Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotary dial subclass? #18

Open
jdee opened this issue Jul 6, 2014 · 1 comment
Open

rotary dial subclass? #18

jdee opened this issue Jul 6, 2014 · 1 comment
Assignees

Comments

@jdee
Copy link
Owner

jdee commented Jul 6, 2014

It might be best to break the knob control into two classes and make the rotary dialer a subclass of the knob control. This would clean up a lot of code. A rotary dialer isn't really a knob, and things like dialNumber: don't really belong in the knob control.

But as an app developer, I like solutions that come in a single code unit, with one .h and one .m file. It's really simple to grab something from GitHub and pop it into a project that way. Hence, I'm reluctant to build a lot of smaller code units and force the use of a framework.

However, I am going to be releasing some other open-source iOS components soon, and the iOS Knob Control will certainly at least be friends with that code base and probably join the family before too long. That project will definitely be a framework with multiple components, and the knob and rotary dial controls would make a nice fit.

This public repo will not go away any time soon, but it's likely over the coming months that this control will be deprecated in favor of the new project.

@jdee jdee self-assigned this Jul 6, 2014
@jdee
Copy link
Owner Author

jdee commented Jul 12, 2014

See iOS Knob Control and Violation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant