fix: 修复 scroll-view 组件在 taro-h5 端的兼容问题 #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #2470 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 149 149
Lines 20390 20390
Branches 2289 2289
=======================================
Hits 17336 17336
Misses 3049 3049
Partials 5 5 |
|
已发布 |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
存在的问题：
Taro 不能将经过 vite 构建后的渲染函数中的
scroll-view标签二次转换为taro-scroll-view-core标签及其对应的 web component 组件，因此会丢失该组件上的属性、方法，导致使用了 scroll-view 的组件的滚动方法失效。解决方案：
通过环境判断，在 h5 环境下直接使用
taro-scroll-view-core标签，在小程序环境下仍然使用scroll-view。涉及到的组件及其功能：
1、Tabs 的滚动居中
2、Elevator 的滚动功能
3、……
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测: