Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 调整组件事件名称 #2536

Merged
merged 5 commits into from
Sep 5, 2023
Merged

fix: 调整组件事件名称 #2536

merged 5 commits into from
Sep 5, 2023

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented Aug 31, 2023

这个 PR 做了什么? (简要描述所做更改)

存在的问题:部分组件的事件名称中存在 on 前缀,并不符合 Vue 组件的命名风格。
调整:

  • 新增不带 on 前缀名称的事件
  • 保留原事件以兼容版本升级,将会在下个大版本移除
    涉及范围:
  • countdown: end、restart、paused
  • invoice: submit
  • navbr: click

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.01% 🎉

Comparison is base (2b1df9c) 84.81% compared to head (f05e225) 84.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2536      +/-   ##
==========================================
+ Coverage   84.81%   84.82%   +0.01%     
==========================================
  Files         150      150              
  Lines       20481    20509      +28     
  Branches     2279     2283       +4     
==========================================
+ Hits        17370    17397      +27     
- Misses       3106     3107       +1     
  Partials        5        5              
Files Changed Coverage Δ
src/packages/__VUE/countdown/index.vue 90.24% <86.66%> (-0.24%) ⬇️
src/packages/__VUE/navbar/index.vue 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu merged commit ed9148e into jdf2e:v4 Sep 5, 2023
5 checks passed
@eiinu eiinu deleted the fix-on-event branch September 5, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant