fix: 日历设置为选择周时，报错：weekDate对象不可迭代 #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v4 #2538 +/- ##
==========================================
- Coverage 84.79% 84.78% -0.02%
==========================================
Files 149 149
Lines 20443 20446 +3
Branches 2281 2281
==========================================
Hits 17335 17335
- Misses 3103 3106 +3
Partials 5 5
☔ View full report in Codecov by Sentry. |
|
@eiinu 大佬 是因为提交前的测试步骤问题，导致 Some checks were not successful 吗 |
这个不用管，覆盖率有略微下降是很常见的。可以把这个PR打开 |
好嘞 |
eiinu
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
存在的问题:
1 日历组件 - 选择周。当未勾选时间并点击'确认'时，报错：Uncaught TypeError: weekDate is not iterable。因为会给handleWeekDate函数传入undefined参数，没有Iterable接口导致无法解构赋值而报错.
2 日历组件中 - nut-cell上展示的文案，使用 date9? 进行三元表达式判断，界面可能会出现 undefined .
调整:
1 type==week时，还需判断chooseData的长度.
2 使用 date9.length? 进行三元表达式判断，未勾选数据时，会展示提示语:'请选择'，而不是 undefined.
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测: