Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(configprovider): move common logic to common file #2540

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

subordon
Copy link
Contributor

@subordon subordon commented Sep 4, 2023

这个 PR 做了什么? (简要描述所做更改)

  • move common logic to common file
  • demo using script setup

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fd89379) 84.79% compared to head (dcb567a) 84.79%.
Report is 1 commits behind head on v4.

Additional details and impacted files
@@           Coverage Diff           @@
##               v4    #2540   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         149      150    +1     
  Lines       20443    20458   +15     
  Branches     2281     2280    -1     
=======================================
+ Hits        17335    17348   +13     
- Misses       3103     3105    +2     
  Partials        5        5           
Files Changed Coverage Δ
src/packages/__VUE/configprovider/common.ts 100.00% <100.00%> (ø)
src/packages/__VUE/configprovider/index.vue 100.00% <100.00%> (+1.31%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu merged commit 1aecf0e into jdf2e:v4 Sep 5, 2023
5 checks passed
@subordon subordon deleted the feature branch September 18, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants