Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picker): 去除columns有值才触发watch监听(#2590) #2611

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

yi-boide
Copy link
Contributor

@yi-boide yi-boide commented Oct 23, 2023

这个 PR 做了什么? (简要描述所做更改)
去除columns有值才触发watch监听(#2590)

这个 PR 是什么类型? (至少选择一个)

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI 4.0 H5
  • NutUI 4.0 小程序
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecc0288) 84.92% compared to head (9dc6470) 84.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v4    #2611   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files         152      152           
  Lines       21172    21172           
  Branches     2377     2378    +1     
=======================================
  Hits        17981    17981           
  Misses       3186     3186           
  Partials        5        5           
Files Coverage Δ
src/packages/__VUE/picker/usePicker.ts 72.19% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eiinu eiinu linked an issue Oct 23, 2023 that may be closed by this pull request
@eiinu eiinu modified the milestones: v4.3.0, v4.2.0 Oct 23, 2023
@eiinu eiinu merged commit 404e732 into jdf2e:v4 Oct 25, 2023
5 checks passed
@yi-boide yi-boide deleted the picker-empty branch October 27, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: 希望 Pickercolumns 能接受空数组
2 participants