fix(swiper): 在动态修改height值后，组件视图未更新 (#2485) #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #2625 +/- ##
==========================================
+ Coverage 84.92% 84.94% +0.01%
==========================================
Files 152 152
Lines 21178 21193 +15
Branches 2379 2386 +7
==========================================
+ Hits 17986 18002 +16
+ Misses 3187 3186 -1
Partials 5 5
☔ View full report in Codecov by Sentry. |
eiinu
reviewed
Oct 30, 2023
| () => props.height, | ||
| (val) => { | ||
| Taro.nextTick(() => { | ||
| init(+val); |
There was a problem hiding this comment.
修改成什么呢？我看其他watch也是这样的
There was a problem hiding this comment.
修改成什么呢？我看其他watch也是这样的
init 方法的参数是激活 swiper-item 的下标，height 的变化不涉及它的变动，应该传空
eiinu
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
swiper在动态修改height值后，组件视图未更新
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测: